Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

directus_collection column icon too small. #574

Closed
Lapsus opened this issue Nov 5, 2018 · 2 comments
Closed

directus_collection column icon too small. #574

Lapsus opened this issue Nov 5, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@Lapsus
Copy link
Contributor

Lapsus commented Nov 5, 2018

Bug Report

Steps to Reproduce

  1. go to admin section -> collections & fields -> select a collection
  2. choose "supervised_user_circle " as icon.
  3. click on save
  4. See error
    "Failed generating the SQL query."
    query: "UPDATE directus_collections SET icon = 'supervised_user_circle', collection = 'COLLECTION_NAME' WHERE collection = 'COLLECTION_NAME'"

Other Context & Screenshots

Column is varchar(20) but apparently there are some icon names exceeding this columns max length.

Technical Details

@benhaynes
Copy link
Sponsor Member

Good catch!

@wellingguzman let's update this database field to 30 characters. That should be enough.

@benhaynes benhaynes transferred this issue from another repository Nov 5, 2018
@benhaynes benhaynes added the bug Something isn't working label Nov 5, 2018
@benhaynes benhaynes added this to Needs triage in Bug Triage via automation Nov 5, 2018
@benhaynes benhaynes added this to To do in v2.0.6 via automation Nov 5, 2018
@wellingguzman wellingguzman moved this from Needs triage to Low priority in Bug Triage Nov 5, 2018
@wellingguzman wellingguzman moved this from To do to In progress in v2.0.6 Nov 5, 2018
Bug Triage automation moved this from Low priority to Closed Nov 5, 2018
v2.0.6 automation moved this from In progress to Done Nov 5, 2018
@wellingguzman
Copy link
Contributor

I've increased the length of directus_collections.icon from 20 to 30.

Ref: 5c1a4cc

samvasko pushed a commit to samvasko/api that referenced this issue Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Bug Triage
  
Closed
v2.0.6
  
Done
Development

No branches or pull requests

3 participants