Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Implement SSO auth flow #94

Closed
rijkvanzanten opened this issue Apr 25, 2018 · 4 comments
Closed

Implement SSO auth flow #94

rijkvanzanten opened this issue Apr 25, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@rijkvanzanten
Copy link
Member

No description provided.

@rijkvanzanten rijkvanzanten added this to To do in v2.0.0-alpha.2 via automation Apr 25, 2018
@rijkvanzanten rijkvanzanten added the enhancement New feature or request label Apr 25, 2018
@rijkvanzanten rijkvanzanten moved this from To do to In progress in v2.0.0-alpha.2 Apr 25, 2018
@rijkvanzanten
Copy link
Member Author

rijkvanzanten commented Apr 25, 2018

The flow:

  1. The application will redirect to the API on /sso/<provider>
  2. The API redirects to the provider (e.g. GitHub/Facebook)
  3. The user logs in on the providers website
  4. Provider redirects back to the API
  5. The API checks the authentication
  6. The API redirects back to the application using the referral domain from the initial step 1 request
    The API adds the data to the query string. If it's an error, it's going to be in the ?error parameter, if it's successful, it will add the token in the token parameter

The main problem to solve: where do we store the initial referral domain from step 1 during the login process on the providers website. At this point, the API will be idle.

@wellingguzman
Copy link
Contributor

We will be adding another step to the flow:

  1. Instead the token from step 6, to be an actual access_token, it will be a "request token" that will be used to request the actual Access Token from the API.

@rijkvanzanten rijkvanzanten moved this from In progress to Done in v2.0.0-alpha.2 Apr 25, 2018
@rijkvanzanten rijkvanzanten moved this from Done to In progress in v2.0.0-alpha.2 Apr 25, 2018
@rijkvanzanten
Copy link
Member Author

There are a couple of errors with the SSO still:

<br />
<b>Fatal error</b>:  Class 'Directus\Authentication\Sso\Provider\GitHub\Provider' not found in
<b>/var/www/directus-demo-api/src/core/Directus/Application/CoreServicesProvider.php</b> on line
<b>771</b>
<br />

@rijkvanzanten rijkvanzanten reopened this Apr 25, 2018
@wellingguzman
Copy link
Contributor

It was an issue with the namespace as because we changed the directory to be lowercase in #99

v2.0.0-alpha.2 automation moved this from In progress to Done Apr 25, 2018
samvasko pushed a commit to samvasko/api that referenced this issue Nov 25, 2019
…ious fixes (directus#94)

* Save options in nested id key

* Save field name translations in fields-<collection>-<key>

Closes directus#83

* Move link to parent listing container

* Persist list view settings per list view

* Add body copy option to v-card

* Add a max height to card content

* Fix margin on v-card

* Make card hover effect more defined
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants