This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parent + Nested validation changes (#1138) * Add migration schema for 2FA Secret user field * Add 2fa_secret field to FieldsSeeder * Create Missing 2FA Password Exception * Add googleauthenticator dependency * Add getter for User's 2FA secret * Check for otp param in login request, and login with it * Add enforce_2fa parameter to directus_settings * Create Utils endpoint and service method to generate 2fa secret * Add enforce_2fa field to roles * Add enforce_2fa field to FieldsSeeder * Change Missing2FAPasswordException error code to 111 * Change 2FA Library * Change 2fa_secret interface in FieldsSeeder * Created exception for invalid otp * Changed findUserWithCredentials to through an InvalidOTPException on otp check * Created new exception if 2fa is enforced but not enabled by user * Added function to check if 2fa is enforced for a user * Check in AuthenticationMiddleware whether 2fa is enforced and enabled for user * Add optional needs2FA field to auth token and on token refresh * Catch error if enforce_2fa column doesn't exist Fixes crash when has2FAEnforced is called on a DB that hasn't been migrated * Use relative positions for target path array to check user edit * Fix unset on payload_arr instead of payload * Change 2FA activation on login to use activate2FA endpoint * Update ItemsService.php
There are cases when $type is not a string but an object that inherits from ObjectType. In that situation array_key_exists failing because it should get only integers or strings as a first parameter. So in order to avoid that the 'name' property of the object is used as a key.
Adds in detection and parsing for youtu.be shorthand URLs.
* added file meta data for audio/video * updates as per PR feedback
* Migrations folder structure * Change migrations path * Remove unwanted utilities * Remove utilities * Add version in comment section of migrations * Check if the table exists or not * Adding if exist condition for update * Rename the fields migrations * Rename api-sample.php to _example.php * Don't return ignored files * Move env out of app config category * Remove timezone flag from config * Move logger config out of settings key * [WIP] Start on new example config file * Change order + remove comments from config stub * Get rid of unused `feedback` config section * Update example config file * Added missing comma * Added missing comma * Remove migration * Adding support for _ project * Add comment for condition * Update Server.php
* File name changes and thumbnailer changes * Thumbnail related changes * name changes * Fix typo * Thumbnail changes * Combine migration files * Replace the file delete code from basetablegateway to fileservice * Tweak migrations * Set uuid to default field format * Don't change primary key of directus_files * Fix content-disposition header + last modified for originals and thumbnails * Don't return thumbnails if the asset type isn't an image * Set duration to readonly * Don't try reading non-images files with Intervention * Prefer application/pdf over application/acrobat * Update repeater settings for asset whitelist * Fix renaming files
* Put old migrations back * Upgrade migrations * Various tweaks * Fix private hash requirement flag The API still throw a required error, even though its a generated field * Fix settings * Rework order of migrations * Beautify directus_files Beautify directus_files Beautify directus_files Beautify directus_files Beautify directus_files Beautify directus_files Beautify directus_files Beautify directus_files Beautify directus_files * Remove nav_blacklist, add enforce_2fa * Tweak settings of timeline * Get rid of activity icon
* Redevelop the 2FA query * Dynamic name of table
benhaynes
approved these changes
Dec 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.