Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clipboard buffer preview configurable #266

Closed
o-sdn-o opened this issue Nov 3, 2022 · 6 comments · Fixed by #267
Closed

Make clipboard buffer preview configurable #266

o-sdn-o opened this issue Nov 3, 2022 · 6 comments · Fixed by #267
Assignees
Labels
enhancement New feature or request UX User Experience

Comments

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Nov 3, 2022

By intent, the clipboard is cleared by pressing the Left+Right mouse buttons. The preview was made to improve security when working with the clipboard, since any program in the terminal can set arbitrary (unsafe) contents of the clipboard.

We need to add a config option to disable clipboard preview.

To disable the clipboard buffer preview just make the following config in ~/.config/vtm/settings.xml:

<config>
    <client>
        <clipboard>
            <preview enabled=false size=80x25 />
        </clipboard>
    </client>
</config>
@o-sdn-o o-sdn-o added enhancement New feature or request UX User Experience labels Nov 3, 2022
@o-sdn-o o-sdn-o self-assigned this Nov 3, 2022
o-sdn-o added a commit that referenced this issue Nov 3, 2022
@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Nov 3, 2022

Hi @AloisKraus! Now you can disable clipboard preview (copied text hovers over the mouse cursor). See #234 and description above for details.

Subsequently, the settings will be through a user-friendly UI, as in a typical GUI app.

@AloisKraus
Copy link

@o-sdn-o: I have tried it. Works perfectly.

<client>
    <clipboard>
        <preview enabled=false size=80x25 />
     </clipboard>

Great work again. Are hotkeys to copy/paste like the standard windows keys Ctrl+C for copy and Ctrl+V for paste already there? I have looked a bit but not found anything in the code so far.

@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Nov 3, 2022

Thanks!

Are hotkeys to copy/paste like the standard windows keys Ctrl+C for copy and Ctrl+V for paste already there?

Unfortunately the hotkeys configuration is not implemented yet. I will start to implement this right after the xml-config #234 implementation is completed. Related to #86.

@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Nov 4, 2022

By intent, the clipboard is cleared by pressing the Left+Right mouse buttons. The preview was made to improve security when working with the clipboard, since any program in the terminal can set arbitrary (unsafe) contents of the clipboard.

@AloisKraus
Copy link

@o-sdn-o: Preview is nice in theory, but in practice I type in the terminal and some text is replaced by the hovered mouse with something copied. Security is also an issue if you replace text while the mouse is hovering and you display wrong output. If the data values are critical you might run into much bigger issues by e.g. formatting the wrong hard drive just because the clipboard security feature was overlaying something which looked like the partition to drive mapping, just the wrong one.

@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Nov 7, 2022

You are right, even for the case of enabled preview, it might also make sense to add auto-hide by mouse inactivity timeout and also add highlighting to make it look like a tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX User Experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants