Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DOSKEY functionality #437

Merged
merged 43 commits into from
Oct 18, 2023
Merged

Conversation

o-sdn-o
Copy link
Collaborator

@o-sdn-o o-sdn-o commented Oct 13, 2023

Changes:

  • Implemented the following APIs (DOSKEY.EXE) support:
    • AddConsoleAlias
    • GetConsoleAlias
    • GetConsoleAliasExesLength
    • GetConsoleAliasExes
    • GetConsoleAliasesLength
    • GetConsoleAliases
    • ExpungeConsoleCommandHistory
    • SetConsoleNumberOfCommands - not used
    • GetConsoleCommandHistoryLength
    • GetConsoleCommandHistory
    • GetConsoleHistoryInfo - not used
    • SetConsoleHistoryInfo - not used
  • Alt+F10 to wipe DOSKEY aliases for current process (by process module name).
  • Alt+F7 to clear command history (by process module name).
  • Processes with the same module name share a common command history.
  • Force 16-color mode on MS Windows prior Windows 10.
  • Implement word-based text wrapping. More window controls #396
  • Add GitHub Action workflow to generate binaries for the big three OS platforms.
  • Disable mouse event processing when any reporting mode enabled. Disable double click toggling window maximization for tui apps with mouse support #438
  • Add the ability to change default menu item settings. How does a minimal configuration with Wrap enabled look like? #439

Closes #396
Closes #428
Closes #438

@AloisKraus
Copy link

When I try this PR i get compilation errors. Is this a problem with my setup?

C:\source\vtm>cmake --build bin --config Release
MSBuild version 17.6.3+07e294721 for .NET Framework

  1>Checking Build System
  Building Custom Rule C:/source/vtm/CMakeLists.txt
  vtm.cpp
C:\source\vtm\src\netxs\desktopio\canvas.hpp(1579,80): error C2131: expression did not evaluate to a constant [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\canvas.hpp(168,49): message : a non-constant (sub-)expression was encountered [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(99,1): error C3313: 'state': variable cannot have the type 'void' [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(100,1): error C3536: 'state': cannot be used before it is initialized [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(110,1): error C3313: 'state': variable cannot have the type 'void' [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(111,1): error C3536: 'state': cannot be used before it is initialized [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(115,1): error C3313: 'state': variable cannot have the type 'void' [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(116,1): error C3536: 'state': cannot be used before it is initialized [C:\source\vtm\bin\vtm.vcxproj]

@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Oct 14, 2023

You may need to update Visual Studio.

My setup (MSBuild version 17.7.2):

D:\sources\test\vstest>cmake --build bin --config Release
MSBuild version 17.7.2+d6990bcfa for .NET Framework

  Checking Build System
  Building Custom Rule D:/sources/test/vstest/CMakeLists.txt
  vtm.cpp
  vtm.vcxproj -> D:\sources\test\vstest\bin\Release\vtm.exe
  Building Custom Rule D:/sources/test/vstest/CMakeLists.txt

D:\sources\test\vstest>

@o-sdn-o

This comment was marked as outdated.

@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Oct 14, 2023

I'll configure github actions for automatic building and it will be easier to test.

@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Oct 15, 2023

Now you can just download the binary from the Checks tab -> Artifacts.

@AloisKraus
Copy link

looks good now. No errors are showing up anymore.
That is great work. Thanks!

@o-sdn-o o-sdn-o merged commit 86f64bb into directvt:master Oct 18, 2023
9 checks passed
@o-sdn-o o-sdn-o deleted the vt-input-mode branch October 18, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants