Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DIR-1502] update UI to get notifications from v2 api #1494

Merged
merged 5 commits into from May 3, 2024
Merged

[DIR-1502] update UI to get notifications from v2 api #1494

merged 5 commits into from May 3, 2024

Conversation

sebxian
Copy link
Contributor

@sebxian sebxian commented Apr 24, 2024 •
edited

Description

Update UI to get notifications from v2 api

To do:

  • Update hooks to consume v2 api
  • Update Notifications component to render available information (waiting for an API update before doing this)

Checklist

  • Documentation updated if required
  • Test coverage is appropriate

Checklist Internal

  • Linear issue linked (e.g. [DIR-XXXX] pull request title)
  • Has the PR been labeled

@sebxian
Update UI to fetch v2 notifications
a3da08c 
Signed-off-by: Sebastian Armbrust <sebastian.armbrust@direktiv.io>
@sebxian
Rename notification hook files
20c537c 
Signed-off-by: Sebastian Armbrust <sebastian.armbrust@direktiv.io>
@sebxian sebxian added the ui UI issues label Apr 24, 2024
@sebxian sebxian marked this pull request as ready for review May 3, 2024 08:35
@sebxian sebxian requested a review from stefan-kracht May 3, 2024 08:35
stefan-kracht
stefan-kracht approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@stefan-kracht stefan-kracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! The new API makes it much cleaner now.

@sebxian sebxian merged commit 8698a50 into main May 3, 2024
17 of 19 checks passed
@sebxian sebxian deleted the sebastianarmbrust/dir-1502-v2-notifications branch May 3, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-kracht stefan-kracht stefan-kracht approved these changes

Assignees
No one assigned
Labels
ui UI issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebxian @stefan-kracht