New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DIR-1444] [DIR-724] [DIR-1506] migrate to new instances api #1497
[DIR-1444] [DIR-724] [DIR-1506] migrate to new instances api #1497
Conversation
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
import { z } from "zod"; export const WorkflowStartedSchema = z.object({ namespace: z.string(), instance: z.string(), }); export const fileNameSchema = z .string() .regex(/^(([a-z][a-z0-9_\-.]*[a-z0-9])|([a-z]))$/, { message: "Please use a name that only contains lowercase letters, use - or _ instead of whitespaces.", }); Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Some comments in the code regarding naming.
I also have one question -- this is probably outside of the scope of this PR, but for clarification: Was there a discussion with the backend guys regarding the format of the filter params? I think they could be improved, and that might also lead to a simplification of currently hard coded stuff in the ui. But that would probably be a separate issue.
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Sebastian Armbrust <sebastian.armbrust@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
No, there was no discussion of changing the query parameters. Maybe we make this is a future ticket and align the params with the event filter ones. |
Signed-off-by: Sebastian Armbrust <sebastian.armbrust@direktiv.io>
Signed-off-by: Sebastian Armbrust <sebastian.armbrust@direktiv.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. As discussed, I pushed some more changes to get all the spelling consistent. Good idea about a follow-up for event & instances filters, I'll keep this in mind while working on the events!
Description
Migrating to the v2 instance API
status === crashed
(the possible statuses were hard-coded in the filter component, I added a direct binding to the schema so that every new status will automatically be added to the filter)api/tree
folder after we migrated all APIs (theFileNameSchema
is the only thing we still use, I moved that intosrc/api/files/schema.ts
)Follow-up tickets
To let us move a bit quicker in the API migration, I added the following task as a separate ticket as I think it is a good iteration and not a mandatory
Checklist
Checklist Internal