Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think direnv should be changed and only emit that error whenever PS1 is part of the diff. #618

Closed
zimbatm opened this issue Apr 7, 2020 · 1 comment

Comments

@zimbatm
Copy link
Member

zimbatm commented Apr 7, 2020

I think direnv should be changed and only emit that error whenever PS1 is part of the diff.

Another workaround is to change the zsh profile configuration to only set, not export the PS1.

Originally posted by @zimbatm in #408 (comment)

@nickray
Copy link
Contributor

nickray commented Jul 16, 2020

Even if PS1 is part of the diff, I feel it's too noisy to emit this warning, as the source may very well be a third party script. For instance, activating Python virtualenvs (source <venv>/bin/activate) triggers this warning.

Given that it's easy to locate the ticket and the wiki entry on this topic, I would suggest reverting #483 entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants