Remove noisy warning about PS1 again #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is no movement on a more specific PS1 warning (as suggested in #618), and there is light support for removing it completely via "thumbs up", putting up this PR for discussion.
As discussed there, it seems to me this warning slipped in due to probably an abundance of PS1 complaints at that time, which should be fixed now that the issue is amply documented. There are likely many other things that "don't work" and could be warned about, so at least from my perspective, there's a wavy line between warning "just in case", vs. the noise this produces, at least in every Python virtualenv-based use case (which can be silenced with
unset PS1, but...).