Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.sh: can specify direnv version #1012

Merged
merged 2 commits into from Nov 3, 2022
Merged

install.sh: can specify direnv version #1012

merged 2 commits into from Nov 3, 2022

Conversation

aabccd021
Copy link
Contributor

Closes #1011

zimbatm
zimbatm approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

zimbatm
zimbatm reviewed Nov 3, 2022
View reviewed changes
install.sh Outdated Show resolved Hide resolved
install.sh Show resolved Hide resolved
@aabccd021 @zimbatm
Apply suggestions from code review
2de7fde 
Co-authored-by: Jonas Chevalier <zimbatm@zimbatm.com>
@zimbatm zimbatm merged commit db00133 into direnv:master Nov 3, 2022
@aabccd021 aabccd021 deleted the install-with-version branch November 3, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Able to specify direnv version when installing with install.sh
2 participants
@aabccd021 @zimbatm