stdlib: direnv_load can now handle stdout outputs #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues where that error message would appear:
direnv: error unmarshal() base64 decoding: illegal base64 data at input byte 0
The issue was that `direnv_load` was reading from the sub-command
stdout, which could also containt content from other commands than
`direnv dump`. This is now solved by opening a fifo pipe between the
load and the dump function.
|
This is great! We have had to be so careful with this before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where that error message would appear (#519) :
The issue was that
direnv_loadwas reading from the sub-commandstdout, which could also containt content from other commands than
direnv dump. This is now solved by opening a fifo pipe between theload and the dump function.