Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add basic windows CI #635

Closed
wants to merge 2 commits into from
Closed

ci: add basic windows CI #635

wants to merge 2 commits into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented May 8, 2020

No description provided.

@zimbatm
Copy link
Member Author

zimbatm commented May 8, 2020

@pjeby it looks like direnv has more Unixism (see rc_test.go). What is the recommended way to deal with paths in a cross-platform manner?

@pjeby
Copy link
Contributor

pjeby commented May 8, 2020

Well, for that test you could just delete the tests and the function they're testing, which is what I did in my WIP because the rootDir function is no longer used anywhere AFAICT. 😉

@zimbatm
Copy link
Member Author

zimbatm commented May 8, 2020

good point. any ideas why the rest of the tests are failing?

@pjeby
Copy link
Contributor

pjeby commented May 8, 2020

The eachDir test is failing because / yields E:\ and E: as parents. (Well, at least on my machine, where the tests are running on E:.) It's a more-or-less reasonable outcome (though the meaning of E: and E:\ are subtly different). I've basically just been skipping that test while figuring out more important stuff.

I'll go ahead and tell you that there are a bunch of shallow failures of this sort elsewhere, like the use of cd -P making paths look wrong when you compare them even though they're actually equivalent. I've got workarounds for some of them, and a few commented out that just aren't going to pass (the empty-var ones) and I also have the symlink-changed test commented out for now as well.

These changes are all in my work tree for the attempt at fixing PATH, which I need to clean out and rebase now that so many other things are in.

@zimbatm
Copy link
Member Author

zimbatm commented May 8, 2020

Ok, it might make sense to pick my commits into your branch then. I will close this PR.

@zimbatm zimbatm closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants