Expand ~/ in whitelist paths
#931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikw
force-pushed
the
feature/tilde_path_expansion
branch
from
12059ba
to
6cc1274
Compare
Expand a path string prefixed with ~/ to the current user's home directory. Example: if current user is `user1` with home directory in `/home/user1`, then `~/project` -> `/home/user1/project` It's useful to allow paths with `~/`, so that `direnv.toml` can be reused via dotfiles repos across systems with different standard home paths (compare Linux `/home` and macOS `/Users`). Feedback is welcome e.g. if/how this should be tested. For now manual testing of prefix & exact has been done confirming that full paths as well as `~/`-paths works. I looked here for how to expand tilde: https://gist.github.com/miguelmota/9ab72c5e342f833123c0b5cfd5aca468 I also found a third party module that expands tilde https://github.com/prep/tilde that we can swap in instead of the `expandTildePath` method in this PR if desired. I assumed the project would like to minimize dependencies and made this simple function instead. Fixes direnv#926
erikw
force-pushed
the
feature/tilde_path_expansion
branch
from
6cc1274
to
7530409
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand a path string prefixed with ~/ to the current user's home directory.
Example: if current user is
user1with home directory in/home/user1,then
~/project->/home/user1/projectIt's useful to allow paths with
~/, so thatdirenv.tomlcan be reused viadotfiles repos across systems with different standard home paths
(compare Linux
/homeand macOS/Users).Feedback is welcome e.g. if/how this should be tested. For now manual
testing of prefix & exact has been done confirming that full paths as
well as
~/-paths works.I looked here for how to expand tilde:
https://gist.github.com/miguelmota/9ab72c5e342f833123c0b5cfd5aca468
I also found a third party module that expands tilde
https://github.com/prep/tilde
that we can swap in instead of the
expandTildePathmethod in this PRif desired. I assumed the project would like to minimize dependencies
and made this simple function instead.
Feel free to amend or push more commits to the PR if wanted!
Fixes #926