Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference repos files in a repos file #241

Open
ghost opened this issue May 27, 2022 · 11 comments
Open

Reference repos files in a repos file #241

ghost opened this issue May 27, 2022 · 11 comments

Comments

@ghost
Copy link

ghost commented May 27, 2022

Consider the following situation:

  • There 15 repositories a team is working on
  • 10 of them are 'core', as in everyone uses them
  • 5 of them are subproject related
  • There are repos files for each, named project1, project2, project3, project4, project5
  • Each repos files includes all 10 core repos

It would be nice to only define the core config once and include or inline it somehow in each project specific definition instead of repeating the same 50 lines 5 times.

Has this been considered before?

@christophebedard
Copy link
Contributor

I worked on this exact feature and have a working prototype, see here: #148

Unfortunately, it didn't go anywhere as far as merging it into this repo.

@ghost
Copy link
Author

ghost commented May 27, 2022

I worked on this exact feature and have a working prototype, see here: #148

Unfortunately, it didn't go anywhere as far as merging it into this repo.

Thanks, I'll take a look

@christophebedard
Copy link
Contributor

It might be possible to extract this feature into a separate tool that takes the "extension" repos file as an input and outputs the combined repos file. Then you could just pipe the output into vcs.

@esteve
Copy link
Contributor

esteve commented Jun 21, 2022

@christophebedard was there anything left to do in #148 ? Or is it a matter of getting more feedback from @dirk-thomas ? Looks to me that your PR already achieves the goal you wanted, right?

@christophebedard
Copy link
Contributor

@esteve yes the PR is pretty complete. I think the repo is in light maintenance mode, since Dirk has stopped needing this tool. Maybe @dirk-thomas would be open to letting other people take over maintainership?

@esteve
Copy link
Contributor

esteve commented Jun 22, 2022

@christophebedard thanks for the info. Given that vcstool is such a fundamental tool for the entire ROS ecosystem, perhaps it'd make sense to move the repository to the @ros organization, what do you think @dirk-thomas ?

@christophebedard
Copy link
Contributor

@esteve should probably bring this up in a https://github.com/ros2/ros2 issue. I think Dirk is enjoying life these days 😄

@esteve
Copy link
Contributor

esteve commented Jun 26, 2022

@christophebedard I've created #242, but if we don't get a response, I'll move the discussion to Discourse

@katettudelft
Copy link

Was there ever any progress on this issue? I've got a very similar use case to the one above.

@christophebedard
Copy link
Contributor

No progress unfortunately.

@esteve
Copy link
Contributor

esteve commented Aug 28, 2023

@christophebedard I opened #242 a long time ago, but didn't get a response from @dirk-thomas . Given that you showed interest in helping maintain vcstool, it'd be good to move or fork the repository somewhere else and fom a group.

cc @nuclearsandwich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants