Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIEnvelope requests too little space #11

Closed
burksbuilds opened this issue Oct 7, 2023 · 1 comment
Closed

UIEnvelope requests too little space #11

burksbuilds opened this issue Oct 7, 2023 · 1 comment

Comments

@burksbuilds
Copy link
Contributor

The UIEnvelope class requests a preferred size based on calling the UISize.cumulateBoth() function to add together the content preferred size and the width/height specified in the 'border' UISize field. The cumulateBoth function adds the width and height of the input UISize once to the output UISize. However, the 'width' and 'height' fields of the UISize border field represent a symmetric thickness that should be applied to both sides of the contained widget, so they should actually be added TWICE to the output UISize.

burksbuilds added a commit to burksbuilds/UiUiUi that referenced this issue Oct 7, 2023
added a second call to cumulateBoth so that the proper size would be requested
burksbuilds added a commit to burksbuilds/UiUiUi that referenced this issue Oct 7, 2023
@dirkhillbrecht
Copy link
Owner

Merged into master, will be included in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants