Allow authentication when LM hash is empty #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to allow authentication when the
-hashes
parameter only contains the NT hash such as:8846f7eaee8fb117ad06bdd830b7586c
.This PR implements a simple fix that checks whether the LM hash is empty, and in that case, it replaces it with the LM hash of the empty string.
A note on
ldap3
: we can basically use an arbitrary 32-character long string for this hash since it does not use it anyway as long as it has the proper length. From ldap3:If the length is different from 32 bytes however, it will compute the NT hash of the string provided and therefore will try to authenticate with wrong credentials.