Huge refactoring: poetry
support, crawl the trusted domains, handle -no-pass
beautifuly and so on.
#177
+2,663
−1,099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @dirkjanm 👋
Overview of Changes:
Kerberos Authentication:
-no-pass
parameter to ensure correct behavior when Kerberos authentication is used without a password.Poetry Integration:
bloodhound.py
file and restructured project directories as needed to fit with poetry conventions.Details
Like this issue mentioned it already, it is currently not respecting the
-no-pass
parameter. So I took the time to make the necessary corrections. It will close #168 tho'.The
args.no_pass
option is intended to skip password prompting (useful when using Kerberos authentication without a password), but there is indeed an issue with how it's handled in the logic for authentication setup. The problem arises in the condition checks where the authentication object (ADAuthentication) is created.In fact, all these checks are unnecessary. We can let the
ADAuthentication
class handle the parameters as it already does when initialized.I've also enabled the script to run even if the user doesn't provide a username. Because it can easily retrieve the TGT username.
Now it works well:
I also added a better resolution for computers too.
Before it was:
Now it is:
I hope you find it all to your liking. For my part, it allows me to continue using your wonderful tool!
Btw, I also adapt the project in order to make-it compatible with
poetry
, which is the modern way to work inside apython3
project. I deleted thebloodhound.py
file as requested by modern projects: