Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Error if scriptSrc is empty #93

Closed
Acconitum opened this issue Jun 17, 2022 · 2 comments
Closed

Fatal Error if scriptSrc is empty #93

Acconitum opened this issue Jun 17, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Acconitum
Copy link

Hi Dirk

I noticed, that there is a fatal error if you leave the scrtiptSrc property (script_src in database) empty within the backend.
I suggest to initiate the srcipt_src column with a default value of an empty string instead of null so the property can still be empty without any fatal errors in the frontend.

TYPO3 Version: 11.5.12
dp_cookieconsent Version: 11.6.2

Let me know if you like me to open a pr for you.

@Acconitum
Copy link
Author

It seems like the error only appears if you create a new entry and leave scriptSrc blank.
If you add a value and delete it right afterwards, TYPO3 will save the new value as an empty string and the error disappear

@DirkPersky DirkPersky added the bug Something isn't working label Jun 17, 2022
@DirkPersky
Copy link
Owner

Let me know if you like me to open a pr for you.

yeah sure, feel free to create a pr.

DirkPersky added a commit that referenced this issue Jun 20, 2022
[BUGFIX] Add default value to script_src column  #93
DirkPersky added a commit that referenced this issue Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants