Remove Hommel

dirkschumacher · Sep 28, 2014 · 99dd19a · 99dd19a
1 parent 32dcaf1
commit 99dd19a
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -57,17 +57,6 @@ julia > padjust(pValues, method = :holm)
  0.5
 ```
 
-#### Hommel
-```jl
-julia > pValues = [0.05, 0.03, 0.01, 0.5]
-julia > padjust(pValues, method = :hommel)
-4-element Array{Float64,1}:
- 0.1  
- 0.075
- 0.04 
- 0.5
-```
-
 ### Control the false discovery rate ([FDR](http://en.wikipedia.org/wiki/False_discovery_rate))
 #### Benjamini-Hochberg
 ```jl

diff --git a/REQUIRE b/REQUIRE
@@ -1 +1 @@
-julia 0.2-
+julia 0.3-
diff --git a/src/PValueAdjust.jl b/src/PValueAdjust.jl
@@ -5,7 +5,6 @@ module PValueAdjust
   export BenjaminiYekutieli
   export Hochberg
   export Holm
-  export Hommel
   export padjust
 
   include("types.jl")
@@ -14,7 +13,6 @@ module PValueAdjust
   include("benjaminiHochberg.jl")
   include("hochberg.jl")
   include("holm.jl")
-  include("hommel.jl")
   include("benjaminiYekutieli.jl")
   include("padjust.jl")
 

diff --git a/src/padjust.jl b/src/padjust.jl
@@ -3,7 +3,6 @@ padjust(pValues::AbstractArray, method::BenjaminiHochbergMethod) = benjaminiHoch
 padjust(pValues::AbstractArray, method::BenjaminiYekutieliMethod) = benjaminiYekutieli(pValues)
 padjust(pValues::AbstractArray, method::HochbergMethod) = hochberg(pValues)
 padjust(pValues::AbstractArray, method::HolmMethod) = holm(pValues)
-padjust(pValues::AbstractArray, method::HommelMethod) = hommel(pValues)
 
 function padjust(pValues::AbstractArray) 
   @check_pValues pValues 

diff --git a/src/types.jl b/src/types.jl
@@ -4,12 +4,10 @@ immutable BenjaminiHochbergMethod <: CorrectionMethod end
 immutable BenjaminiYekutieliMethod <: CorrectionMethod end
 immutable HochbergMethod <: CorrectionMethod end
 immutable HolmMethod <: CorrectionMethod end
-immutable HommelMethod <: CorrectionMethod end
 
 # some constants
 Bonferroni = BonferroniMethod()
 BenjaminiHochberg = BenjaminiHochbergMethod()
 BenjaminiYekutieli = BenjaminiYekutieliMethod()
 Hochberg = HochbergMethod()
-Holm = HolmMethod()
-Hommel = HommelMethod()
+Holm = HolmMethod()
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,7 +1,6 @@
 tests = [
     "bonferroni",
     "holm",
-    "hommel",
     "hochberg",
     "benjaminiHochberg",
     "benjaminiYekutieli",