Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not solving the issue yet #39

Closed
wants to merge 8 commits into from
Closed

Not solving the issue yet #39

wants to merge 8 commits into from

Conversation

maelle
Copy link

@maelle maelle commented Jul 10, 2016

In this PR I

ERROR: dependency 'ompr' is not available for package 'ompr.roi'
* removing 'c:/RLibrary/ompr.roi'
Error: Command failed (1)
Execution halted

so I'll now look for how to deal with this.

@maelle
Copy link
Author

maelle commented Jul 10, 2016

Note that I added my own secure Github PAT so you should change this, see krlmlr/r-appveyor#33

@coveralls
Copy link

coveralls commented Jul 10, 2016

Coverage Status

Coverage remained the same at 94.2% when pulling 53811f8 on masalmon:master into 87c8542 on dirkschumacher:master.

@coveralls
Copy link

coveralls commented Jul 10, 2016

Coverage Status

Coverage remained the same at 94.2% when pulling 01ffe6d on masalmon:master into 87c8542 on dirkschumacher:master.

@coveralls
Copy link

coveralls commented Jul 10, 2016

Coverage Status

Coverage remained the same at 94.2% when pulling 840e4ef on masalmon:master into 87c8542 on dirkschumacher:master.

@maelle
Copy link
Author

maelle commented Jul 10, 2016

Now the build is no longer failing because of the unit tests, it is failing because of 3 warnings due to undocumented things. Cf #40

@maelle maelle mentioned this pull request Jul 10, 2016
@coveralls
Copy link

coveralls commented Jul 10, 2016

Coverage Status

Coverage remained the same at 94.2% when pulling 9885327 on masalmon:master into 87c8542 on dirkschumacher:master.

@coveralls
Copy link

coveralls commented Jul 10, 2016

Coverage Status

Coverage remained the same at 94.2% when pulling 9885327 on masalmon:master into 87c8542 on dirkschumacher:master.

@coveralls
Copy link

coveralls commented Jul 10, 2016

Coverage Status

Coverage remained the same at 94.2% when pulling ef7fd5b on masalmon:master into 87c8542 on dirkschumacher:master.

@dirkschumacher
Copy link
Owner

Thanks a lot again for figuring out what the problem was. I would suggest two options:

  • Either, I pick the changes and make the commits myself
  • Or, you split the PR into two separate PRs (one for the Code of Conduct and one for Appveyor). Please then use imperative style commit message and just one commit per change. I would like to keep the commit history as clean as possible.

@maelle
Copy link
Author

maelle commented Jul 18, 2016

I'll let you pick the changes because I won't have much time. 😊

@maelle maelle closed this Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants