Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msrv and unpin cfg-if. #32

Closed
wants to merge 1 commit into from

Conversation

dvc94ch
Copy link

@dvc94ch dvc94ch commented Jun 24, 2020

No description provided.

@soc
Copy link
Collaborator

soc commented Jun 24, 2020

What's the intention of this?

@dvc94ch
Copy link
Author

dvc94ch commented Jun 24, 2020

It causes a failure to resolve the dependency if there is another dependency in the graph is using a higher version. Not sure why cargo doesn't include it twice in the dependency graph.

@dvc94ch
Copy link
Author

dvc94ch commented Jun 25, 2020

So? Do you want me to create a reproducible test case? It's not like I waste my time with PR's to working code

@soc
Copy link
Collaborator

soc commented Jun 26, 2020

No, it's fine. I'll probably go the #26 route and drop cfg-if instead.

@dvc94ch dvc94ch mentioned this pull request Jun 26, 2020
@dvc94ch dvc94ch closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants