Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for Pro Drums Mode #8

Closed
ebellumat opened this issue Jul 30, 2020 · 3 comments · Fixed by #9
Closed

[Feature Request] Add support for Pro Drums Mode #8

ebellumat opened this issue Jul 30, 2020 · 3 comments · Fixed by #9

Comments

@ebellumat
Copy link

Hello! Moonscraper Chart Editor have and special mode called "Pro Drums" that is used in Rock band, Clone Hero and Beat Smith Drum Songs, that consists in 3 colors that can be uses as cymbals or toms.

This screenshot shows these gold notes in blue and green lanes, this notes are read in the games as cymbal notes.

image

This is the final result on Beat Smith as example with this special mode.

https://youtu.be/F1tdru0giPw

Can you add the support to add the flag on cymbal notes on chart file? You can check the discussion here.

FireFox2000000/Moonscraper-Chart-Editor#37

And more details here.

http://docs.c3universe.com/rbndocs/index.php?title=Drum_Authoring#Displaying_Tom_Gems

And you can check this chart as an example.

https://drive.google.com/drive/folders/1JWzjJ7pxckQQG7UyUR80hOAOTSmNJQTl

I hope this links can help on implementation!

@Dirtmigurt
Copy link
Owner

I've only ever played Guitar Hero's 5 lane drums and assumed thats what people were interested in.
I have looked into what RB Pro drums are and how they are represented, and it seems 4 Lane + Pro is the way that the Customs community is going so I will change the implementation to support that.

@ebellumat
Copy link
Author

Thanks for your time and your reply!

And, what you think about Beat Smith?

You think will be a good game? :D

@FireFox2000000
Copy link

I'm keeping track of the changes we're making to the chart format to support pro drums outside of the midi spec which you can find here-
https://docs.google.com/document/d/1v2v0U-9HQ5qHeccpExDOLJ5CMPZZ3QytPmAG5WF0Kzs

Doubles kicks will most likely be added on note 32, but will only update the spec once that's properly in, in case there's any finals changes we make.

@Dirtmigurt Dirtmigurt linked a pull request Aug 1, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants