Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Am I affected by the bug?" is misleading #2

Open
glasser opened this issue Oct 20, 2016 · 3 comments
Open

"Am I affected by the bug?" is misleading #2

glasser opened this issue Oct 20, 2016 · 3 comments

Comments

@glasser
Copy link

glasser commented Oct 20, 2016

I went to this site on my Mac and saw:

Am I affected by the bug?
Nope.

When I read that, I interpreted this as meaning: This may be a security hole, but it's not a huge deal; we're just making a funny page for it for the hell of it. You don't have to worry about any Linux servers you maintain.

I did not interpret it as meaning "The particular web browser you're using to access this page runs on a system that isn't affected by the bug."

I'd suggest being more clear. (Plus, it doesn't actually detect whether you're running a fixed kernel or not, so even if you understand that the text is dynamic, it's not that helpful.)

@Physicist1616
Copy link

Physicist1616 commented Oct 25, 2016

Just tested and confirmed @glasser's last parenthetical remark. The "Am I affected by the bug?" section fails to account for systems running the fixed 4.8.4 kernel.
$ uname -a
Linux arch 4.8.4-1-ARCH #1 SMP PREEMPT Sat Oct 22 18:26:57 CEST 2016 x86_64 GNU/Linux

@daveloyall
Copy link

I presumed that the page is static. It doesn't look dynamic.

@jlu5
Copy link

jlu5 commented Oct 27, 2016

@daveloyall That part is actually a JavaScript snippet which looks for "Android" or "Linux" in the user agent: https://github.com/dirtycow/dirtycow.github.io/blob/master/index.html#L64-L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants