-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement slash command and new webhook endpoints #64
Implement slash command and new webhook endpoints #64
Conversation
…agement endpoint implementations
…slash command implementations
…feature/slash-commands
This reverts commit 469314d.
Since this has been silent for a while, I'd like to note that the two main remaining issues now are: 1. How to handle parameter names and spec All spec definitions are located in the same namespace (and currently need to for the 2. Application ID |
Leaving this here as a checklist for myself:
|
My honeymoon is nearly over, and when I get back I plan on working through this PR. Hopefully this can be in a good state soon! |
I've thought about a possible solution to the specs issue. Perhaps you could allow putting the endpoint name in the namespace of a spec. |
Following up on (some of) the issue of rate limits: |
FYI, the permissions feature for commands was merged. It doesn't seem to be on the website yet, but it's in discord/discord-api-docs master. |
discord/discord-api-docs#2410 latest comment describes 2 new endpoints to get existing webhook messages and the original interaction response. Will be adding that shortly after testing the most recent changes (file uploads) and implementing them for the create interaction response endpoint. |
All slash commands features should be implemented and functional now. |
Awesome, I'll do a little review this morning and see what the status of permissions are on discord's documentation, but we should be good to merge soon. |
Docs are still lacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good in all, but there's a couple minor changes.
This PR makes the following changes:
There are some things left to do and clean up:
(positional or optional for consistency with old endpoints?) - right now it is implemented to be consistent with the old code
Unfortunately my testing capabilities are rather limited until 2 weeks from now or so.
I can respond to requests for changes already though, so feel free to review.