Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

Fix Issue #37 #52

Merged
merged 5 commits into from
May 27, 2015
Merged

Fix Issue #37 #52

merged 5 commits into from
May 27, 2015

Conversation

leo-dor
Copy link
Contributor

@leo-dor leo-dor commented May 23, 2015

Fix Issue #37 -- allow to clone properly on Windows.

  • Renamed all test files to replace '?' with '_'
  • Changed FileSystemFetcher to likewise replace '?' with '_' when loading a test file
  • Added logic to FileSystemFetcher to check for all permutations of parameters contained in a test file's name.
  • Removed symlinks from repo.
  • The repo now clones cleanly on Windows.
  • Unit tests passed.

@leo-dor leo-dor changed the title Fix Fix Issue 37 May 23, 2015
@leo-dor leo-dor changed the title Fix Issue 37 Fix Issue #37 May 23, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 85.14% when pulling a9a81ef on leo-dor:master into 7571d03 on discogs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 85.14% when pulling a9a81ef on leo-dor:master into 7571d03 on discogs:master.

try:
path = path.replace('?', '_') # this fixes Issue 37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this comment here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.14%) to 84.93% when pulling 02891c9 on leo-dor:master into 7571d03 on discogs:master.

@leo-dor
Copy link
Contributor Author

leo-dor commented May 27, 2015

Thanks for the feedback, comments fixed.

@rodneykeeling
Copy link
Contributor

Thanks, this looks good to me. I'll see if I can have another developer take a second look as well.

👍

@vreon
Copy link
Member

vreon commented May 27, 2015

LGTM 👍

rodneykeeling added a commit that referenced this pull request May 27, 2015
@rodneykeeling rodneykeeling merged commit 91974be into discogs:master May 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants