Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to support settings_schema.json. #22

Open
gavinballard opened this issue May 16, 2015 · 3 comments
Open

Rewrite to support settings_schema.json. #22

gavinballard opened this issue May 16, 2015 · 3 comments

Comments

@gavinballard
Copy link
Member

With the new settings_schema.json settings format replacing settings.html in Shopify themes, this plugin is currently deprecated.

This issue exists to gauge interest in reviving it with support for settings_schema.json. The new JSON format is much easier to maintain than the old settings.html, but it still suffers from a few issues:

  • No support for splitting settings up into individual files;
  • No support for repeated sections;
  • JSON syntax is still quite verbose.

An updated version of grunt-shopify-theme-settings would provide support for the above features, while using the simple YAML syntax of the original and compile down to JSON.

@nathanparker
Copy link

Hey @gavinballard - I've rewritten the settings.html file to convert to a settings_schema.json. Let me know if you'd like to check out the code.

@gavinballard
Copy link
Member Author

Hey @nathanparker! I don't generally have the time to maintain this repository, so while I'm happy to review pull requests to bring something like a new shopify_convert_settings task into the package, I'm unable to write it myself.

If you're willing to write a PR for this, I promise I'll take a look :).

@jonathan-bird
Copy link

@nathanparker did you end up checking out the code and creating a repo? We'd love to use it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants