Fix flake8 #178
Merged
Fix flake8 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumix
reviewed
May 31, 2023
| from discopy.grammar import thue | ||
| from discopy.rigid import Ob | ||
| from discopy.rigid import Ob # noqa: F401 |
There was a problem hiding this comment.
Can we avoid this # noqa F401 by adding Ob to adding an __all__ variable to the module?
There was a problem hiding this comment.
In this case we really want the unused import because e.g. lambeq uses from discopy.grammar.pregroup import Ob
toumix
reviewed
May 31, 2023
toumix
reviewed
May 31, 2023
toumix
reviewed
May 31, 2023
discopy/symmetric.py
Outdated
| from discopy.cat import factory | ||
| from discopy.monoidal import Ob, Ty, PRO | ||
| from discopy.monoidal import Ty, PRO |
There was a problem hiding this comment.
I would say as a rule of thumb it's nice if every module has it's own Ob even when it's just imported from another. In that way you can from discopy.symmetric import * and you get Ob.
toumix
reviewed
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.