Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings #50

Merged
merged 4 commits into from Aug 4, 2020
Merged

Fix some warnings #50

merged 4 commits into from Aug 4, 2020

Conversation

elikoga
Copy link
Contributor

@elikoga elikoga commented Jul 21, 2020

Removes redundant imports issuing warning: [-Wunused-imports] on compile time

Adds type signatures to literals issuing error: [-Wtype-defaults, -Werror=type-defaults] on compile time when compiled with stack build --pedantic

@aquarial
Copy link
Collaborator

The import Data.Monoid ((<>)) let's the project build on an older version of base that doesn't import it by default.

I get home Sunday or so, and I'll take a look to see if that base is so out of date it's just worth dropping, or we should use compiler pragma guards or something.

I agree the pile of warnings isn't nice.

@aquarial aquarial merged commit cddf3db into discord-haskell:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants