Refactored to Monad Stack #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure about the mondad stack stuff, but I noticed #34 has 4 thumbs up, seems like a popular request! I looked over this pr and the changes seem reasonable. I'll merge this, and get up to speed on this stuff. I'll update the Readme and examples on Sunday when I get back home |
|
there's a merge conflict. I can't fix it from mobile |
|
I think the merge conflict should be resolved now |
|
Alright |
Closed
elikoga
added a commit
to elikoga/discord-haskell
that referenced
this pull request
Jul 22, 2020
aquarial
added a commit
that referenced
this pull request
Jul 22, 2020
Updated example in README to reflect #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
DiscordHandle -> IO atoDiscordHandler aMonad Transformer StackI oriented myself around this guide: https://thoughtbot.com/blog/refactoring-to-a-monad-transformer-stack
This was mentioned in #34