Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(caching): implemented cache customization #186

Merged
merged 2 commits into from Jun 13, 2023

Conversation

seailz
Copy link
Member

@seailz seailz commented Jun 13, 2023

Pull Request

  • I have checked the PRs for upcoming features/bug fixes.

Changes

  • Internal code
  • Library
  • Documentation

Description

Allows the dev using discord.jar to customize what types are cached. If a type is not meant to be cached, then it will be grabbed fresh from the API each time that it is needed.

@seailz seailz added type: feature Issue or PR is a feature that should be implemented priority: medium Medium priority status: completed status: awaiting testing labels Jun 13, 2023
@seailz seailz added this to the discord.jar 1.0 milestone Jun 13, 2023
@seailz seailz self-assigned this Jun 13, 2023
…caching not working if cacheTypes had only CacheType.ALL
@seailz seailz merged commit deaee07 into main Jun 13, 2023
3 checks passed
@seailz seailz deleted the feature/cache-customization branch June 13, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium priority status: completed type: feature Issue or PR is a feature that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant