Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendFile on a Nitro Boosted Guild #1243

Closed
3 tasks done
zoemartin01 opened this issue Mar 27, 2020 · 7 comments
Closed
3 tasks done

sendFile on a Nitro Boosted Guild #1243

zoemartin01 opened this issue Mar 27, 2020 · 7 comments
Labels
bug status: completed has been completed but is not yet released

Comments

@zoemartin01
Copy link

zoemartin01 commented Mar 27, 2020

General Troubleshooting

  • I have checked for similar issues.
  • I have updated to the latest JDA version.
  • I have checked the branches or the maintainers' PRs for upcoming features.

Feature Request

As the sendFile(File, String, AttachmentOption) Method is not overwritten in TextChannel it uses the MessageChannel method which checks only checks the users max. allowed file size but not the servers. On a Server with nitro boost level 2/3 that check isn't accurate anymore because also non-nitro users and bots can send attachments as big as 50MiB or 100MiB respectively.

default MessageAction sendFile(@Nonnull File file, @Nonnull String fileName, @Nonnull AttachmentOption... options) {
...
Checks.check(file.length() <= getJDA().getSelfUser().getAllowedFileSize(),
                "File is too big! Max file-size is 8 MiB for normal and 50 MiB for nitro users");
...
}
@Andre601
Copy link
Contributor

Andre601 commented Mar 27, 2020

From what I understand is there no confirmation in the docs, that would proof, that the boost level also influences the file-size a bot can upload.

If you find a clear confirmation within the official docs, that proof this, then please provide us the link.

@Andre601
Copy link
Contributor

Additionally does JDA use the SelfUser and not the SelfMember as shown by your code-snipped.
This is most likely because the Member Object doesn't have an option to see what the file-size is, that they can upload.

I can't even find any kind of documentation that would list limitations of the attachments a bot can upload.

@zoemartin01
Copy link
Author

The official documentation isn't well detailed when it comes to boost tier perks. I cannot find anything stating the specific tier perks in the developer portal. The only thing that comes close is this screenshot I took in the app itself, when looking at a Guilds boost tab.
Screenshot 2020-03-27 at 16 20 28

@sebm253
Copy link
Contributor

sebm253 commented Mar 27, 2020

The question is if boost tiers limit bots.

@zoemartin01
Copy link
Author

Well I know that bots are also affected by the 100MiB limit for a level 3 Guild since I built my own JDA version with the check removed, tried it on my server and it works with files > 8MiB. But I don't have any official documentation for that.

@Andre601
Copy link
Contributor

Well I know that bots are also affected by the 100MiB limit for a level 3 Guild since I built my own JDA version with the check removed, tried it on my server and it works with files > 8MiB. But I don't have any official documentation for that.

Without any official documentation confirming this will that probably not be changes because it could also be a bug in the eyes of the Discord Devs and could therefore be fixed
I suggest you open an issue on the GitHub about the API-docs to propose adding this information to said docs, so that we have a confirmation on Discord's side that this indeed is intended behaviour.

@MinnDevelopment
Copy link
Member

I'm pretty sure all the boost benefits also apply to bots.

@MinnDevelopment MinnDevelopment added the status: completed has been completed but is not yet released label Apr 9, 2020
Andre601 added a commit to Andre601/JDA that referenced this issue May 21, 2020
* Fix description for RestAction#flatMap

* Remove invalid NSFW info

* Fix bug in buffer allocation for ZlibDecompressor

* Don't insert null into override cache

* Keep a strong reference to user from members

Fake members will use fake users that are not cached

* Add functionality to set/get state of embed suppression (discord-jda#1117)

* Add functionality to set/get state of embed suppression

* Provide Enum for MessageFlags

* Improve handling of events for unavailable guilds (discord-jda#1184)

* Improve handling of events for unavailable guilds
* Add UnavailableGuildLeaveEvent
* Update docs for Guild#isAvailable

* Improve ratelimit bucket handling (discord-jda#1103)

* Let ChannelUpdateHandler add overrides to cache

This is a bug since the override shouldn't be in the interface
if the member is not actually in the cache. With the current
implementation we have a cache inconsistency that could NPE.

* Change handling of GuildDeleteHandler to avoid deadlock

There really is no point in holding a write-lock here

* Bump version

* Add South Korea Region

* Add getPermissionHolder method to PermissionOverride (discord-jda#1183)

* Make ignored events for unavailable guilds a debug log

* Add ErrorHandler utility class (discord-jda#1200)

* Add ErrorHandler utility class
* Improve logging of 429 warnings

* Add clearReactions(String) (discord-jda#1192)

* Add clearReactions(String)
* Add MessageReactionRemoveEmoteEvent
* Fix some outdated documentation
* Log and rethrow errors in BotRateLimiter workers

* Properly encode reaction emoji for clearReactionsById(...)

* Updated all copyright headers for 2020 (discord-jda#1198)

* Add (Guild) Invite Events (discord-jda#1196)

Adds GuildInviteCreateEvent and GuildInviteDeleteEvent

* Allow queued requests to finish

* Support gateway intents and configurable member caching (discord-jda#1190)

* First pass on member cache policy
* Add INVALID_INTENTS to close code enum
* Deprecate AccountType.CLIENT
* Add Guild#unloadMembers
* Update README with better examples
* Improve handling of channel overrides
* Add documentation for intents and member cache policy
* Remove references to guild subscriptions
* Add GuildMemberRemoveEvent
* Improve retrieveMemberById and retrieveUserById
* Changes to the builders, we use factory methods now :)
* Disable presence cache by default
* Add JDA#getGatewayIntents

* Fix NPE for GUILD_UPDATE handling

* Fix GuildChannel#createCopy for uncached members (discord-jda#1229)

* Deprecate GuildUpdateBannerEvent#getNewBannerIdUrl (discord-jda#1217)

* Allow to open private channel with user id (discord-jda#1224)

* Change defaults for requester to be non-daemon and have a shorter timeout (discord-jda#1215)

* Added Server Insights permission (discord-jda#1221)

* Add RestAction#timeout and RestAction#deadline (discord-jda#1220)

* Fix NPE in PermissionOverrideAction constructor

* Fix another NPE in success handler

* Documentation updates (discord-jda#1222)

* Swapped manage server and manage channel in Invite#isExpanded docs (discord-jda#1210)
* Document another possible null return case of Message#getMember (discord-jda#1204)
* Fix EmbedBuilder constructor javadocs (discord-jda#1214)
* Update example for jda-nas
* Add more details to modifyMemberRoles docs
* Fix typo

* Added getGuildChannelById methods to ShardManager (discord-jda#1234)

* Add better configuration methods to the builders (discord-jda#1240)

* Update README
* Add enableCache and disableCache
* Add enableIntents and disableIntents
* Update docs for events to mention required intents when necessary.
* Deprecate the old setters for cache flags

* Include voice server endpoint in connection failure logs

* Initialize SelfUser for all shards before logging them in

* Fix bug with new channel overrides having incorrect permissions

* Add the close code to the disconnect warn

* Adding a check in reaction methods before calling getTextChannel() (discord-jda#1216)

* Add JDA#cancelRequests (discord-jda#1223)

* Fix boost time not being handled in guild create

* Add GuildVoiceStreamEvent

* Fix IllegalStateException in Requester

Closes discord-jda#1254

* Change reconnect code to 4900 to avoid confusion (discord-jda#1250)

* Change reconnect code to 4900 to avoid confusion
* And update the disconnect handling to better log things
* Make resume reconnect log on debug
* Log server error on error level
* Add catch in gateway worker

* Add Guild#getMaxFileSize and Guild.BoostTier#getMaxFileSize (discord-jda#1244)

Fixes discord-jda#1243

* Add fallback operators onErrorMap and onErrorFlatMap to RestAction (discord-jda#1219)

* Fix incorrect file size check

* Documentation updates (discord-jda#1241)

* Add note about presence update and member intents
* Fix typo in readme
* Add MessageChannel#retrieveReactionUsersById and update reaction related docs (discord-jda#1236)
* Add requirements section to member/user events

* Json Parsing Optimizations (discord-jda#1267)

* Remove initial reconnect delay for resumes

* Add prune overload to disable wait parameter

* Add Guild#retrieveMetaData (discord-jda#1171)

* Lazy load member limits for guilds
* Improve implementation of update handler
* Add Guild#retrieveMetaData

* Add check for heartbeats in WebSocketClient (discord-jda#1282)

* Add retrieveMembersByPrefix (discord-jda#1276)

* Add retrieveMemberByPrefix
* Add event pool configuration
* Fix javadoc errors
* Rename chunkSyncQueue -> chunkQueue

* Create file if it doesn't exist in downloadToFile

* Add members to cache from retrieveMember methods

* Improve handling of join times for members

* Add Message.JUMP_URL_PATTERN

* Replace disconnect handling to recover from strange thread states (discord-jda#1295)

* Shutdown the WebSocket connection after everything else

* Use executor to shutdown in DefaultShardManager

* Add methods to bulk retrieve members (discord-jda#1292)

* Add methods to bulk retrieve members
* Add documentation
* Add missing annotations to Task interface
* Use random number as nonce

* Improvements to handling of Error (discord-jda#1285)

* Remove usage of AssertionError
* Improve handling of Errors

* Change domain to discord.com (discord-jda#1288)

* Fix NPE in ChannelManager#sync

* Add User#getFlags (discord-jda#1271)

* Add Emote#isAvailable() method

Co-authored-by: Florian Spieß <business@minnced.club>
Co-authored-by: Michael Ritter <ritter.michael92@gmail.com>
Co-authored-by: horyu1234 <horyu1234@naver.com>
Co-authored-by: DMan <DManstrator@users.noreply.github.com>
Co-authored-by: Austin Keener <keeneraustin@yahoo.com>
Co-authored-by: averen <31487840+averen@users.noreply.github.com>
Co-authored-by: Mathéo CIMBARO <25774021+DiscowZombie@users.noreply.github.com>
Co-authored-by: Artuto <artutogamer@gmail.com>
Co-authored-by: Nik <nik@monsterlyrics.co>
Co-authored-by: Sebo Molnár <git@mlnr.dev>
Co-authored-by: gpluscb <20143778+gpluscb@users.noreply.github.com>
Co-authored-by: Napster <napster@npstr.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status: completed has been completed but is not yet released
Projects
None yet
Development

No branches or pull requests

4 participants