Fix incorrect size check for MessageChannel#sendFile

[gpluscb]

Pull Request Etiquette

• I have checked the PRs for upcoming features/bug fixes.
• I have read the contributing guidelines.

Changes

• Internal code
• Library interface (affecting end-user code)
• Documentation
• Other: _____

Closes Issue: NaN

Description

Fixes an issue where the byte[] overload of MessageChannel#sendFile
does not check permissions and ignores guild boosts in the max allowed size check.

[MinnDevelopment]

For your info, it does check permissions since the sendFile(String, byte[]) just calls sendFile(String, InputStream) which does have an override.

[gpluscb]

Should this behaviour be changed?
The recently added TextChannelImpl/PrivateChannelImpl#sendFile(File, String, AttachmentOption...) methods have the same behaviour, so it would make sense to change these as well if this is going to be changed.

[MinnDevelopment]

Well, checking permissions twice is kind of redundant. However, the code flow here is confusing, as you can probably tell. I'm fine either way, your call.

[gpluscb]

In that case I am going to leave it in for clarity sake.