Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement per-guild avatars #1649

Merged
merged 12 commits into from
Oct 23, 2021
Merged

Implement per-guild avatars #1649

merged 12 commits into from
Oct 23, 2021

Conversation

RedDaedalus
Copy link
Contributor

@RedDaedalus RedDaedalus commented Jun 5, 2021 •
edited by MinnDevelopment
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This pull request implements per-guild avatars (discord/discord-api-docs#3081). These additions have been tested and do work. It is still unclear whether bots will be able to access these.

@MinnDevelopment MinnDevelopment added the status: freezer this is currently put on hold label Jun 5, 2021
@Andre601
Copy link
Contributor

Andre601 commented Jun 6, 2021

The docs PR says it's not available for bots yet.
And when it isn't available for bots is there imo no need for this PR.

@Sanduhr32
Copy link
Contributor

The docs PR says it's not available for bots yet.
And when it isn't available for bots is there imo no need for this PR.

Where does it introduce a way for a bot to set a guild avatar Andre? Correct non yet. This is basically read-only support for now. Why would it matter if bots could set per-guild avatars?
Afaict this is basic API functionality for clients and bots.

@Andre601
Copy link
Contributor

Andre601 commented Jun 6, 2021

Where does it introduce a way for a bot to set a guild avatar Andre? Correct non yet. This is basically read-only support for now. Why would it matter if bots could set per-guild avatars?
Afaict this is basic API functionality for clients and bots.

The PR comment says Per guild avatars are rolled out to a small percentage of users and do not seem to be currently accessible to bots. which can mean both that bots can't set a per-guild avatar but also that they can't access per-guild avatars of users yet.

@RedDaedalus
Copy link
Contributor Author

Where does it introduce a way for a bot to set a guild avatar Andre? Correct non yet. This is basically read-only support for now. Why would it matter if bots could set per-guild avatars?
Afaict this is basic API functionality for clients and bots.

The PR comment says Per guild avatars are rolled out to a small percentage of users and do not seem to be currently accessible to bots. which can mean both that bots can't set a per-guild avatar but also that they can't access per-guild avatars of users yet.

You are misinterpreting this, that is specifically referring to setting them, anyone can read them:
Screen Shot 2021-06-06 at 11 33 13 AM

@RedDaedalus
Copy link
Contributor Author

The docs pr has been merged and reviews have been addressed.

@DV8FromTheWorld DV8FromTheWorld removed the status: freezer this is currently put on hold label Oct 3, 2021
@DV8FromTheWorld DV8FromTheWorld merged commit 6f67977 into discord-jda:development Oct 23, 2021
aasmart added a commit to aasmart/JDA that referenced this pull request Oct 25, 2021
@aasmart
Revert "Implement per-guild avatars (discord-jda#1649)"
078e3c8 
This reverts commit 6f67977.
This was referenced Jan 8, 2022
Merged
Closed
@renovate renovate bot mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andre601 Andre601 Andre601 left review comments

@MinnDevelopment MinnDevelopment MinnDevelopment left review comments

@averen averen averen left review comments

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RedDaedalus @Andre601 @Sanduhr32 @DV8FromTheWorld @MinnDevelopment @averen