Create ID alternatives to permission override methods in ChannelManager #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
requested changes
Aug 5, 2021
Co-authored-by: Florian Spieß <business@minnced.club>
MinnDevelopment
requested changes
Sep 3, 2021
Co-authored-by: Florian Spieß <business@minnced.club>
MinnDevelopment
approved these changes
Sep 7, 2021
This was referenced Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Description
This provides ID-powered alternatives to
putPermissionOverride/removePermissionOverrideonChannelManager. This allows for permissions to be safely modified on a channel without relying on an up-to-date cache.Conspicuously missing is the ID-string equivalent to all of these methods, which I could add if needed but it doubles the number of new methods so I decided against it for now.