Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some documentation on //todo-v5: docs #1838

Merged
merged 24 commits into from
Jan 19, 2022
Merged

Some documentation on //todo-v5: docs #1838

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
31f8869
Fixes regression of Command Option Choice name limit from 100 -> 25
oliver276 Sep 2, 2021
0b299e1
Renames constant MAX_NAME_OPTION_LENGTH -> MAX_CHOICE_NAME_LENGTH
oliver276 Sep 2, 2021
cb33bd8
Fixes docs to correctly reference the Choice names.
oliver276 Sep 2, 2021
1ddbadc
Update docs for affected methods
oliver276 Sep 2, 2021
eefbb27
Merge branch 'v5' of https://github.com/DV8FromTheWorld/JDA into patch-1
oliver276 Sep 19, 2021
47b1bb6
Write up some more documentation
oliver276 Sep 21, 2021
1a2bbb1
Add some extra information about crossposting
oliver276 Sep 22, 2021
0d8fc3f
Merge branch 'v5' of https://github.com/DV8FromTheWorld/JDA into patch-1
oliver276 Sep 29, 2021
509a2be
Update bitrate docs
oliver276 Oct 9, 2021
674081d
Merge branch 'master' of https://github.com/DV8FromTheWorld/JDA into …
oliver276 Nov 30, 2021
64cbe9f
Adds extra TODOs where documentation is missing
oliver276 Nov 30, 2021
90eafcf
Adds more documentation of new keys, also formats so all generic keys…
oliver276 Nov 30, 2021
3a2bb03
Documented the ThreadHiddenEvent and ThreadRevealedEvent
oliver276 Dec 10, 2021
8e332b5
Merge branch 'master' of https://github.com/DV8FromTheWorld/JDA into …
oliver276 Dec 16, 2021
c1499ab
Fixes from PR review.
oliver276 Dec 24, 2021
7183868
some more work. I should commit and push more often
oliver276 Jan 10, 2022
07c5372
Nearly done
oliver276 Jan 11, 2022
8b858f8
Merge branch 'master' of https://github.com/DV8FromTheWorld/JDA into …
oliver276 Jan 11, 2022
a1ce2aa
Document additional error responses
oliver276 Jan 16, 2022
bf9ab38
Merge branch 'master' of https://github.com/DV8FromTheWorld/JDA into …
oliver276 Jan 16, 2022
8e906e8
Apply changes from code review
oliver276 Jan 16, 2022
a8f9005
Add more information to ThreadMember caching behaviour
oliver276 Jan 17, 2022
5375d1a
Merge branch 'master' of https://github.com/DV8FromTheWorld/JDA into …
oliver276 Jan 19, 2022
6cf61ed
Apply fixes from code review
oliver276 Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/net/dv8tion/jda/api/entities/ThreadChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ default ThreadMember getSelfThreadMember()
* For this reason, {@link #retrieveThreadMembers()} should be used instead in most cases.
*
* <p>The cache this method relies on is empty until JDA sees a member join via a {@link net.dv8tion.jda.api.events.thread.member.ThreadMemberJoinEvent}.
* In order for this cache to be updated, the following requirements must be met:
* <br>If this thread is spawned from a message sent <i>by this account</i>, then this account will be added to the cache.
oliver276 marked this conversation as resolved.
Show resolved Hide resolved
* Threads created from other members' messages do not share this behavior.
* <br>In order for this cache to be updated, the following requirements must be met:
* <ul>
* <li>the {@link net.dv8tion.jda.api.requests.GatewayIntent#GUILD_MEMBERS} intent must be enabled.</li>
* <li>the bot must be able to join the thread (either via the {@link net.dv8tion.jda.api.Permission#MANAGE_THREADS MANAGE_THREADS} permission, or a public thread)</li>
Expand Down