Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding messages with embeds and components #1873

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

duncte123
Copy link
Contributor

@duncte123 duncte123 commented Nov 2, 2021

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #1872

Description

Fixes override(true) not clearing the embeds on a message. My assumption is that discord treats null the same way as the field not being present, hence sending an empty array fixes it.

@Andre601
Copy link
Contributor

Andre601 commented Nov 2, 2021

From my testing should this work as providing a Collections.emptyList() does the trick.

@duncte123
Copy link
Contributor Author

From my testing should this work as providing a Collections.emptyList() does the trick.

I had the same thought, just wanted to make sure that it did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants