Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ErrorResponse values #1892

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

Xirado
Copy link
Contributor

@Xirado Xirado commented Nov 10, 2021

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This pull requests adds all missing ErrorResponse Enum values.

@Andre601
Copy link
Contributor

I spotted two things that confuse me a bit:

  1. The longest enum name had no spaces after the (, so it was NAME(1234, "text") but your change adds spaces where they aren't really needed.
  2. Numbers are padded on the left, so that they line up on the right, which your change is not following:
    # Original
     123
    1234
    
    # Your change
    123
    1234
    

Those are obviously only visual changes, but I still believe they should be something important to consider. But let's wait for the input of Minn or DV8.

@DV8FromTheWorld DV8FromTheWorld deleted the branch discord-jda:master November 30, 2021 00:07
@DV8FromTheWorld DV8FromTheWorld changed the base branch from v5 to master November 30, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants