-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement retrieveThreadMember #1919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
added
the
status: documentation needed
lacks documentation, either partially or completely
label
Nov 30, 2021
src/main/java/net/dv8tion/jda/internal/entities/ThreadChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/ThreadChannelImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Spieß <business@minn.dev>
Tais993
changed the title
Implemented retrieveThreadMember
Implement retrieveThreadMember
Dec 11, 2021
Added documentation after request from @DV8FromTheWorld on the Discord (excuse the delay) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor nits
MinnDevelopment
added
type: feature
and removed
status: documentation needed
lacks documentation, either partially or completely
labels
Dec 16, 2021
MinnDevelopment
approved these changes
Dec 19, 2021
DV8FromTheWorld
approved these changes
Dec 24, 2021
This was referenced Dec 24, 2021
This was referenced Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Implements the retrieveThreadMember(ById) methods including their documentation