Only update CommandData limiting booleans for non-empty additions #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanduhr32
changed the title
| @@ -142,7 +142,8 @@ public CommandData addOptions(@Nonnull OptionData... options) | |||
| Checks.noneNull(options, "Option"); | |||
| Checks.check(options.length + this.options.length() <= 25, "Cannot have more than 25 options for a command!"); | |||
| Checks.check(allowOption, "You cannot mix options with subcommands/groups."); | |||
| allowSubcommands = allowGroups = false; | |||
| if (options.length > 0) | |||
| allowSubcommands = allowGroups = false; | |||
There was a problem hiding this comment.
You should just return if length = 0, also this check should be before the mixing of options check is done.
change check oder & return this
MinnDevelopment
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Fixes that you can't "mix" options & subcommand (groups) after adding an empty set of these complementary types.
Only updates booleans for non-empty sets.