Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MessageEmbed#getUrl docs to mention representing the title url #1975

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Change MessageEmbed#getUrl docs to mention representing the title url #1975

merged 2 commits into from
Jan 21, 2022

Conversation

sebm253
Copy link
Contributor

@sebm253 sebm253 commented Dec 29, 2021

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

this PR changes the MessageEmbed#getUrl docs to mention that it may represent the title url if the type of the embed is EmbedType#RICH.

@MinnDevelopment MinnDevelopment added this to the 5.0.0-alpha.5 milestone Jan 10, 2022
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get the one comment handled and then this is Good To Go

Co-authored-by: Austin Keener <keeneraustin@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants