Change PrivateChannel#getUser to handle API nullability #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: + PrivateChannels may not always have a User + PrivateChannels contain a convenience retrieveUser method + JDA#retrieveChannelById + Reaction events no longer wait for the channel to be cached + The GET_CHANNEL route, for retrieving channels
oliver276
force-pushed
the
feature/direct_message_nullables
branch
from
71c8941
to
5b1306d
Compare
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/handle/MessageReactionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
DV8FromTheWorld
added
type: breaking
DV8FromTheWorld
changed the title
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Spieß <business@minn.dev>
src/main/java/net/dv8tion/jda/api/events/message/react/GenericMessageReactionEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Spieß <business@minn.dev>
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Spieß <business@minn.dev>
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
…information to populate it
…Impl.java Co-authored-by: Florian Spieß <business@minn.dev>
MinnDevelopment
approved these changes
Feb 19, 2022
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/PrivateChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/handle/MessageReactionHandler.java
Show resolved
Hide resolved
Co-authored-by: Austin Keener <keeneraustin@yahoo.com>
DV8FromTheWorld
approved these changes
Feb 20, 2022
This was referenced Feb 20, 2022
Closed
This was referenced Mar 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Project Card: https://github.com/DV8FromTheWorld/JDA/projects/5#card-68160406
Description
Changes: