Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed excessive non-alphanumeric check #2021

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Removed excessive non-alphanumeric check #2021

merged 4 commits into from
Feb 11, 2022

Conversation

RobotHanzo
Copy link
Contributor

@RobotHanzo RobotHanzo commented Feb 7, 2022 •
edited
Loading

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.
  • I have read the contributing guidelines.

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #2020

Description

This PR is a follow-up of issue #2020 to remove an excessive non-alphanumeric check put on GuildAction.ChannelData

@RobotHanzo RobotHanzo mentioned this pull request Feb 7, 2022
Closed
3 tasks
MinnDevelopment
MinnDevelopment requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@MinnDevelopment MinnDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the respective documentation for the constructor and GuildAction#newChannel. They still say it throws for the invalid name.

@RobotHanzo
Copy link
Contributor Author

Please also update the respective documentation for the constructor and GuildAction#newChannel. They still say it throws for the invalid name.

Done.

@DV8FromTheWorld DV8FromTheWorld merged commit 7f6402d into discord-jda:master Feb 11, 2022
This was referenced Feb 20, 2022
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 3, 2022
Closed
Closed
@renovate renovate bot mentioned this pull request Mar 13, 2022
Closed
1 task
@RobotHanzo RobotHanzo deleted the patch-1 branch April 10, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

@MinnDevelopment MinnDevelopment MinnDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RobotHanzo @DV8FromTheWorld @MinnDevelopment