Remove unnecessary processing in ErrorResponse#test(ErrorResponse...

[java-coding-prodigy]

Pull Request Etiquette

• I have checked the PRs for upcoming features/bug fixes.
• I have read the contributing guidelines.

Changes

• Internal code
• Library interface (affecting end-user code)
• Documentation
• Other: _____

Closes Issue: NaN

Description

• Currently, ErrorResponse#test(ErrorResponse... produces an EnumSet of the responses, which it then passes to ErroResponse#test(Collection
• That method however, creates another EnumSet, which is unnecessary processing.
• To fix that, this PR will create its own predicate without calling the other method.

[java-coding-prodigy]

I seem to have messed something up, GitHub shows a lot of other commits somehow.

Should I have compared with master instead of development?

[Chew]

Yes, change the target to master

[java-coding-prodigy]

Yes, change the target to master

Oh thanks, it worked, I thought we had to compare with development.

[java-coding-prodigy]

However, my change does create a small amount of code duplication, to combat this, I was considering making a private method which returns a Predicate<Throwable> with the parameters of EnumSet<ErrorResponse>