prevent creating OptionData with OptionType#UNKNOWN #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/net/dv8tion/jda/api/interactions/commands/build/OptionData.java
Show resolved
Hide resolved
MinnDevelopment
approved these changes
Apr 20, 2022
DV8FromTheWorld
requested changes
Apr 20, 2022
src/main/java/net/dv8tion/jda/api/interactions/commands/build/OptionData.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/interactions/commands/build/OptionData.java
Show resolved
Hide resolved
|
requested changes will be addressed in a followup pr. |
DV8FromTheWorld
approved these changes
Apr 20, 2022
This was referenced Apr 25, 2022
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
this PR adds a check to
OptionDataconstructor which prevents successfully creating an instance withOptionType#UNKNOWN(prevents things like #2100 from happening).