Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo correction #2206

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Typo correction #2206

merged 1 commit into from
Aug 18, 2022

Conversation

Gregor7008
Copy link
Contributor

@Gregor7008 Gregor7008 commented Aug 7, 2022 •
edited

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Quick Typo correction in net.dv8tion.jda.utils.SimpleLogger - Lines #39, #64 and #144
Was: "Loggerger" - Is: "Logger"

DV8FromTheWorld
DV8FromTheWorld approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but im honestly confused how it's gone this long without anyone noticing

@DV8FromTheWorld
Copy link
Member

We might need to communicate that the file name for the Configuration file changed just in case someone was using the "incorrectly" named variant

@DV8FromTheWorld DV8FromTheWorld merged commit 67566a8 into discord-jda:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

@Thibstars Thibstars Thibstars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gregor7008 @DV8FromTheWorld @Thibstars