Return immutable reconstructed interaction object lists #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freya022
changed the title
src/main/java/net/dv8tion/jda/api/entities/IPermissionContainer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Spieß <business@minn.dev>
MinnDevelopment
approved these changes
Aug 21, 2022
This was referenced Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
I have seen that some interaction related methods were returning mutable lists, causing difficult to diagnose bugs, this makes sure the stream collector returns an unmodifiable list.
While there's a lot of other methods which could fail due to manipulating reconstructed objects, it is at least simple to prevent the users to add options, for example.
Other issues not covered by the PR include adding translations to an OptionData after adding it to the command