Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for empty token in AuthorizationConfig, instead of JDAImpl #2230

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Check for empty token in AuthorizationConfig, instead of JDAImpl #2230

merged 2 commits into from
Oct 23, 2022

Conversation

freya022
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

JDAImpl was doing unnecessary checks and could had been implemented where the token comes from, so, AuthorizationConfig, the PR moves the notEmpty check there

@MinnDevelopment
Copy link
Member

Can you also add a check for noWhitespace?

@MinnDevelopment MinnDevelopment merged commit 8520369 into discord-jda:master Oct 23, 2022
@freya022 freya022 deleted the refactor/token-check branch April 11, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinnDevelopment MinnDevelopment MinnDevelopment approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freya022 @MinnDevelopment