Handle messages from inaccessible threads and add webhook support #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
added
type: enhancement
type: semi-breaking
…essages # Conflicts: # src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java # src/main/java/net/dv8tion/jda/internal/entities/ReceivedMessage.java # src/main/java/net/dv8tion/jda/internal/entities/SystemMessage.java # src/main/java/net/dv8tion/jda/internal/handle/InteractionCreateHandler.java # src/main/java/net/dv8tion/jda/internal/interactions/InteractionHookImpl.java
MinnDevelopment
changed the title
MinnDevelopment
changed the title
Vankka
reviewed
Jun 16, 2023
MinnDevelopment
added
the
beta-blocker
MinnDevelopment
commented
Sep 26, 2023
src/main/java/net/dv8tion/jda/api/interactions/Interaction.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/requests/restaction/AbstractWebhookMessageAction.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/requests/restaction/ThreadCreateMetadata.java
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/InteractionHookImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/interactions/component/ComponentInteractionImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/requests/restaction/MessageEditActionImpl.java
Outdated
Show resolved
Hide resolved
…essages # Conflicts: # src/main/java/net/dv8tion/jda/api/entities/channel/ChannelType.java
MinnDevelopment
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Adds support for sending webhook messages and handle interactions from hidden threads.
Summary
WebhookClient.createClient(jda, url), which allows sending webhook messagesInteractionHook.from(jda, interactionToken), which allows sending followup messages for interactionsMessageto be usable without a channel or guild. This is necessary for WebhookClient and InteractionHook, where the channel is potentially not reachable by the bot.Message#hasChannelandMessage#hasGuildto check whether a channel or guild is provided by the message instanceMessageReactionaccordinglychannelobjectsSystemMessagein favor of simple checks inReceivedMessageEntityBuildernow has new methods for creating messages in webhooks:createMessageFromWebhookcreates a message instance without a channel, but potentially a guild instancecreateMessageBestEffortcreates a message instance based on the provided channel and guild (or null in case of not being accessible)