Add getting cache flags from events #2558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andre601
suggested changes
Oct 7, 2023
There was a problem hiding this comment.
As per the Structure Guide:
If the class is not already imported, use the fully qualified name when you are inking to something through JavaDoc!
Bad:{@link RestAction}
Good:@link net.dv8tion.jda.core.requests.RestAction RestAction}
You are creating imports that are only used for the JavaDoc which is not a good aproach here. In fact are there inconsistencies in your JavaDoc (i.e. using {@link Guild#getPublicRole() @everyone} but then later using the full path for the Guild class)
src/test/java/net/dv8tion/jda/GatewayIntentRequirementsTest.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/guild/override/GenericPermissionOverrideEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/guild/override/GenericPermissionOverrideEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/api/events/guild/override/PermissionOverrideUpdateEvent.java
Outdated
Show resolved
Hide resolved
freya022
added a commit
to freya022/BotCommands
that referenced
this pull request
Oct 27, 2023
Preparing for discord-jda/JDA#2558
freya022
force-pushed
the
feature/cache-flag-from-events
branch
from
f98bd83
to
44e57a9
Compare
|
For reference, here is how aa6788d is made: Generate requirement annotations.patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Allows getting cache flags from events, also fixes documented requirements of scheduled events, and clarifies permission overrides events
Replaces getting cache flags / gateway intents using annotations