Adds support for user's avatar decorations #2668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oration avatar as ImageProxy
| * @return The never-null SKU id of the {@link User User} decoration avatar. | ||
| */ | ||
| @Nonnull | ||
| public String getSkuId() |
There was a problem hiding this comment.
How is this useful to a bot?
There was a problem hiding this comment.
I'm not sure how for now, but maybe JDA will add support for SKU later on? Should I just remove that entirely?
Co-authored-by: Florian Spieß <business@minn.dev>
|
|
|
Do I use the same object present in User for adding support in Member? |
|
Yes, same object, but stored on the member, just like any member profile element that's also present on an user |
|
As |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Adds support for the user's decoration avatar. Discord docs are outdated about the user's object, check this PR for the "updated" endpoints.